Skip to content

chore: kill show AST commands#262

Merged
brandonspark merged 5 commits intodevelopfrom
brandon/kill-extraneous-commands
Sep 2, 2025
Merged

chore: kill show AST commands#262
brandonspark merged 5 commits intodevelopfrom
brandon/kill-extraneous-commands

Conversation

@brandonspark
Copy link
Contributor

@brandonspark brandonspark commented Aug 25, 2025

These are annoying and no one uses them. They just cause friction for the developer. Let's kill it.

Test plan:

Verified that the commands are gone on right click, now.

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@brandonspark brandonspark requested a review from liukatkat August 25, 2025 16:24
Copy link
Contributor

@liukatkat liukatkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

I get these errors when I start the extension with this change. I think we might need to clean up all the references to these commands.

@brandonspark
Copy link
Contributor Author

image.png

I get these errors when I start the extension with this change. I think we might need to clean up all the references to these commands.

whoops, silly of me, fixed now

@brandonspark brandonspark requested a review from liukatkat August 28, 2025 20:31
Copy link
Contributor

@liukatkat liukatkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also remove the things related to showAST in lspExtension.ts but this looks good!

@brandonspark brandonspark merged commit 3427c1d into develop Sep 2, 2025
11 checks passed
@brandonspark brandonspark deleted the brandon/kill-extraneous-commands branch September 2, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants